On 04/12/2017 09:48 AM, Martin Kletzander wrote:
QEMU will likely report the details of it shutting down, particularly the system it received in case it was killed. We should forward that information along. Since the only way we can extend information provided to the user is adding event details, we might as well emit multiple events (one with the reason for the shutdown and keep the one for the shutdown being finished for clarity and compatibility).
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1384007
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- This is waiting for a patch in QEMU [1] that I tested this with.
[1] https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg01098.html
The discussion on the qemu patch says it will probably not expose signal names, but merely a boolean of guest- vs. host-initiated. So you'll have to respin on top of whatever qemu settles on, but the idea is sane. You are correct that since we can't expand the existing event, we have to add a second one, and wire up both events to fire at once (we've done it before, so there's precedence). -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org