Re: [libvirt] [PATCHv3 2/2] audit: audit use of /dev/net/tun, /dev/tapN, /dev/vhost-net
On 03/10/2011 09:16 AM, Laine Stump wrote:
On 03/09/2011 03:42 PM, Eric Blake wrote:
> Opening raw network devices with the intent of passing those fds to
> qemu is worth an audit point.
<long commit message>
Hmm, we really ought to have some sort of documentation that describes
all possible audit messages, but that can be a separate patch.
> +++ b/src/qemu/qemu_hotplug.c
> @@ -576,7 +576,8 @@ int qemuDomainAttachNetDevice(virConnectPtr conn,
> return -1;
> }
>
> - if ((tapfd = qemuNetworkIfaceConnect(conn, driver, net,
> qemuCaps))< 0)
> + if ((tapfd = qemuNetworkIfaceConnect(vm->def, conn, driver, net,
> + qemuCaps))< 0)
This part needed some tweaks to rebase on top of the modified 1/2.
Pretty mechanical, though.
ACK
Thanks; pushed.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)