On 11/18/2013 03:44 PM, Doug Goldstein wrote:
The case label for VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED did not have its own break statement but relied on falling through which we probably don't want. --- libvirt-override.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/libvirt-override.c b/libvirt-override.c index c3ff1e0..03f6253 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -6409,6 +6409,7 @@ libvirt_virConnectDomainEventRegisterAny(ATTRIBUTE_UNUSED PyObject * self, #if LIBVIR_CHECK_VERSION(1,1,1) case VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED: cb = VIR_DOMAIN_EVENT_CALLBACK(libvirt_virConnectDomainEventDeviceRemovedCallback); + break; #endif /* LIBVIR_CHECK_VERSION(1,1,1) */
ACK; we may want to push this one upstream first as trivial before doing the libvirt-python split. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org