[PATCH 00/39] String cleaning

It's spring, let's clean up some string cruft. Peter Krempa (39): qemuDomainStorageSourceValidateDepth: Define chain depth as macro virStorageSourceGetMetadata: Use depth limit instead of unique path checking Remove virStorageSourceGetUniqueIdentifier file backend API storage_file: Remove virStorageFileBackendFsPriv virStorageFileBackendGlusterPriv: Remove 'canonpaht' tests: Remove testing of virStorageFileCanonicalizePath Remove virStorageFileCanonicalizePath virDomainDiskAddISCSIPoolSourceHost: use g_strsplit instead of virStringSplitCount virJSONValueObjectDeflattenWorker: use g_strsplit instead of virStringSplitCount virStorageFileParseBackingStoreStr: use g_strsplit instead of virStringSplitCount util: virlog: Use g_auto(GStrv) instead of g_strfreev in cleanup section util: virlog: Remove pointless 'cleanup' labels virLogParseOutputs: Refactor string list handling virLogParseFilters: Refactor string list handling virLogParseFilter: Replace virStringSplitCount by g_strsplit virLogParseOutput: Replace virStringSplitCount by g_strsplit virshParseEventStr: Use g_strsplit and automatic memory freeing bhyveParsePCIFbuf: Use g_strsplit instead of virStringSplitCount virHostValidateGetCPUFlags: Use g_strsplit instead of virStringSplitCount virshParseRateStr: Refactor cleanup virshParseRateStr: Use g_strsplit instead of virStringSplitCount virStorageSourceParseBackingJSONUriCookies: Use g_strsplit instead of virStringSplitCount storage: zfs: Don't split string if we need only first/last component virStorageBackendZFSRefreshPool: Reduce scope of 'tokens' storage: zfs: Use g_strsplit instead of virStringSplitCount virResctrlGetCacheInfo: Restrict variable scope and use automatic freeing virResctrlAllocNewFromInfo: Restrict variable scope and use automatic freeing virResctrlAllocNewFromInfo: Use g_autoptr for 'ret' virResctrlAllocGetUnused: Use g_autoptr for variables of virResctrlAlloc type util: virresctrl: Use automatic memory freeing util: virresctrl: Remove empty 'cleanup' sections util: virresctrl: Use g_strsplit instead of virStringSplitCount xenParsePCI: Replace virStringSplitCount by g_strsplit xenParseXLVnuma: Replace virStringSplitCount by g_strsplit openvzParseBarrierLimit: Rework string handling virSystemdActivationInitFromNames: Replace virStringSplit by g_strsplit virVMXParseConfig: Replace virStringSplitCount by g_strsplit util: virstring: Remove the virStringSplitCount wrapper funcion tests: string: Remove pointless test for virStringListFreeCount src/bhyve/bhyve_parse_command.c | 14 +- src/conf/domain_conf.c | 5 +- src/libvirt_private.syms | 3 - src/libxl/xen_common.c | 5 +- src/libxl/xen_xl.c | 4 +- src/openvz/openvz_conf.c | 21 +- src/qemu/qemu_domain.c | 7 +- src/security/virt-aa-helper.c | 5 +- src/storage/storage_backend_zfs.c | 31 +- src/storage_file/storage_file_backend.h | 4 - src/storage_file/storage_file_backend_fs.c | 44 --- .../storage_file_backend_gluster.c | 73 ----- src/storage_file/storage_source.c | 81 ++--- src/storage_file/storage_source.h | 1 + .../storage_source_backingstore.c | 9 +- src/util/virjson.c | 5 +- src/util/virlog.c | 86 +++--- src/util/virresctrl.c | 279 +++++++----------- src/util/virstoragefile.c | 215 +------------- src/util/virstoragefile.h | 8 - src/util/virstring.c | 20 -- src/util/virstring.h | 6 - src/util/virsystemd.c | 9 +- src/vmx/vmx.c | 7 +- tests/virstoragetest.c | 103 +------ tests/virstringtest.c | 23 -- tools/virsh-domain.c | 39 +-- tools/virt-host-validate-common.c | 13 +- 28 files changed, 237 insertions(+), 883 deletions(-) -- 2.29.2