On Fri, Nov 29, 2013 at 04:18:40PM +0100, Cédric Bosdonnat wrote:
--- src/conf/domain_event.c | 46 +++++++++++++++++++++++----------------------- src/conf/domain_event.h | 4 ++-- 2 files changed, 25 insertions(+), 25 deletions(-)
Interesting that the header file change didn't cause problems elsewhere in the codebase. This is a sign that we should just move the typedef out of the header and into .c file instead as nothing needs it publicised.
diff --git a/src/conf/domain_event.h b/src/conf/domain_event.h index 07b14c4..2fe7731 100644 --- a/src/conf/domain_event.h +++ b/src/conf/domain_event.h @@ -41,8 +41,8 @@ typedef virDomainEventCallbackList *virDomainEventCallbackListPtr; typedef struct _virDomainEvent virDomainEvent; typedef virDomainEvent *virDomainEventPtr;
-typedef struct _virDomainEventQueue virDomainEventQueue; -typedef virDomainEventQueue *virDomainEventQueuePtr; +typedef struct _virObjectEventQueue virObjectEventQueue; +typedef virObjectEventQueue *virObjectEventQueuePtr;
eg move these into domain_event.c Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|