Re: [libvirt] [PATCH v2] qemu: read backing chain names from qemu

On 03/13/2015 02:02 AM, Peter Krempa wrote: >> @@ -16172,8 +16169,12 @@ qemuDomainBlockJobImpl(virDomainObjPtr vm, >> } >> >> qemuDomainObjEnterMonitor(driver, vm); >> - ret = qemuMonitorBlockJob(priv->mon, device, basePath, backingPath, >> - speed, mode, async); >> + if (baseSource) >> + basePath = qemuMonitorDiskNameLookup(priv->mon, device, disk->src, > > I remember that at some point accessing of domain definition while in > the monitor was not okay for some reason, but I can't now remember why > nor whether it was fixed. Oh, right. You're thinking of CVE-2013-6458. That problem was that as soon as we enter the monitor, we drop locks. If we do not already own a block job, then some other parallel API could be hot-unplugging a disk before we regain control, freeing 'disk' before we dereference it. But we fixed that problem by guaranteeing that we always own the job early enough (no other thread can hot-unplug the disk as long as we own the job), so it is not an issue for this patch. >> - * Copyright (C) 2006-2014 Red Hat, Inc. >> + * Copyright (C) 2006-2015 Red Hat, Inc. > > Shouldn't we employ something as in gnulib, where copyrights would be > bumped at once everywhere? Might be nice, but one wrinkle. Gnulib has a single copyright holder (FSF), so they can afford to bump all files at once (the bump is also owned by FSF, so FSF adding another year to its copyright is appropriate). But libvirt is split among multiple copyright holders - Red Hat can't claim copyright over all files, so it wouldn't be wise to bump all files, just the ones that Red Hat has already touched. Personally, I've just got an emacs hook that checks if any file I touch has an up-to-date copyright line.