Re: [libvirt] [PATCH 04/14] virsh-completer: switch to using tmp instead of ret
On Mon, Apr 01, 2019 at 09:33:21 +0200, Ján Tomko wrote:
Construct the potential return value in an array called
'tmp'
and only assign it to 'ret' if we're going to return it.
This will allow us to unify the error and success paths.
Signed-off-by: Ján Tomko <jtomko(a)redhat.com>
---
tools/virsh-completer.c | 195 +++++++++++++++++++++++++---------------
1 file changed, 125 insertions(+), 70 deletions(-)
There's at least 1 unrelated whitespace change.
ACK regardless.
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)