On 06/18/2010 10:29 AM, Justin Clift wrote:
On 06/19/2010 02:23 AM, Eric Blake wrote: <snip>
If a translation of one of those headers is longer than the field width in your printf format string, it may lead to awkward formatting in other languages. But you're not the first instance of that issue, and it is not a show-stopper for this patch (rather, it points to something that we may want to clean up in the future).
Agreed. The vol-list patch shouldn't exhibit this problem though, as I pretty much rewrote it not to.
After you've taken a look at the vol-list patch, if you reckon the approach there is ok then I can redo this patch in the same way fairly easily. Probably better to get this solved from the outset rather than adding more stuff to adjust later.
Your call. I was about to push 1/2 after making the minor tweaks, but then I saw this email, so I'm leaving the decision up to you whether you'd rather have pool-list touched twice (add --details, then add smart-width) or just once (rewrite to do smart-width of --details from the start). -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org