Re: [libvirt] [PATCH 1/3] qemu: add capability for vhost-net busy polling
On 06/17/2017 09:15 PM, Eduardo Habkost wrote:
(CCing qemu-devel and the QAPI maintainers. I have a question
about introspection below.)
Fortunately, netdev options are modelled in the QAPI schema as
union Netdev. However, 'query-qmp-schema' doesn't seem to
include union Netdev because it is not referenced by any QMP
command or event.
I've posted patches in the past (qemu 2.6 timeframe, if I recall) that
changed netdev_add into a fully-advertised interface, but we didn't take
it then because we weren't sure how to handle the fact that netdev_add
can currently accept both an integer (1) and a string ("1") as
identical, and we didn't want to risk breaking clients that passed a
string when the promoted command would only accept integers. I guess we
should revive that.
Markus, Eric, Michael: is there any way libvirt can query the
definition of union Netdev from the schema with current QEMU?
Really, we need to promote netdev_add to a full-fledged QMP command.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)