On Tue, Sep 09, 2014 at 10:45:47AM +0200, Peter Krempa wrote:
Test the qemu command generator and the xml parsers and formatters. The tests are added separately due to the size of the test files.
Note that tests/qemuxml2argvdata/qemuxml2argv-disk-virtio-raw.args is split into lines in a weird way as "sc_prohibit_long_lines" forced me to.
+ <disk type='network' device='disk'> + <driver name='qemu' type='qcow2'/> + <source protocol='nbd' name='bar'> + <host transport='unix' socket='/var/run/nbdsock'/> + </source> + <backingStore type='block' index='1'> + <format type='qcow2'/> + <source dev='/dev/HostVG/QEMUGuest1'/> + <backingStore type='file' index='2'> + <format type='qcow2'/> + <source file='/tmp/image2.qcow'/> + <backingStore type='file' index='3'> + <format type='qcow2'/> + <source file='/tmp/image3.qcow'/> + <backingStore type='file' index='4'> + <format type='qcow2'/> + <source file='/tmp/image4.qcow'/> + <backingStore type='file' index='5'> + <source file='/tmp/image5.qcow'/> + <format type='qcow2'/> + <backingStore type='raw' index='6'> + <format type='qcow2'/> + <source raw='json: { "file.driver":"file", "file.filename":"/libvirt/bsdf.img"}'/>
NACK precisely because it allows this kind of arbitrary passthrough of QEMU specific command syntax. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|