Re: [libvirt] [PATCH 1/5] Enhance the streams helper to support plain file I/O
On 03/15/2011 06:30 AM, Daniel P. Berrange wrote:
+ if (offset &&
+ lseek(fd, offset, SEEK_SET) != offset) {
+ virReportSystemError(errno,
+ _("Unable to seek %s to %llu"),
+ path, offset);
+ goto error;
+ }
One more thing to think about - since unsigned long long is unsigned,
but off_t used by lseek is signed, do we need to worry about overflow or
other out-of-bounds problems?
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)