On Thu, Aug 12, 2021 at 04:48:53PM +0200, Peter Krempa wrote:
Hi,
this series started as an exploration in how we use
'query-command-line-options' and the way to possibly step away from
using it. The main problem is that query-command-line-options is using
old-style command line parsing infra in qemu and thus doesn't scale.
In an effor to help qemu developers identify what we still need to query
using the command I set to clean up the parsing.
This series consists of:
- removal of unneeded tests (covered by other cases or pointless)
- adding of comments which simplify lookup of capability string from
enum value name
- grouping of the queries by name
- refactor of probing of stuff which can be probed differently
- removal of some other probes
- cleanups of the driver code
In general we've got the following cases:
- good ones:
- can be queried differently
- this patchset has converted (probably) all of them
- the "bad" ones:
- stuff we can't replace yet and we need to probe it, few examples
are:
- pressence of seccomp
- support of 'fd=' for chardevs
- various VNC and spice config options
- the possibly "ugly":
- these are options which are supported by all qemu versions and are
unlikely to be removed, but there's no different way to probe
them, we can always assume them
- those are the QEMU_CAPS_NAME* and QEMU_CAPS_MSG_TIMESTAMP at the
end, these patches are RFC as it may be considered a backwards
step just to assume it's supported
You mean if these were removed we would be in trouble since older
libvirt would not work with new enough qemu? i do not see that as a
possible issue, I think we'd notice some deprecation in advance.
So from me (given the obvious fix in PATCH 04/22) this is
Reviewed-by: Martin Kletzander <mkletzan(a)redhat.com>
but feel free to wait for more responses on the RFC parts.