Re: [libvirt] [PATCH 0/5] parallels: continue rewriting code to use sdk
On Tuesday 14 October 2014 18:23:31 you wrote:
This patch series replaces a series of functions, which
retieve different domains info and modifies domains state
with new ones, which use parallels sdk instead of executing
prlctl command.
These functions don't use cached domains list
_parallelsConn.domains, so when we rewrite all code, we
will be able to remove it.
Hello,
We have decided to keep the list of domains parallelsConn.domains.
To keep it up-to-date we subscribe to events from PCS and modify
it when events about new, removed or changed domains occur.
It's better because first, the file parallels_driver.c will be similar
to corresponding files in other drivers, so it'll be easier to maintain
it, second, it will be faster, because requesting domain info from PCS
takes some time, and also it needs less modifications of current code.
So, please, don't review these patches, I've already implemented this
new approach and will send it today or tomorrow.
Alexander Burluka (1):
parallels: obtain domain info with SDK
Dmitry Guryanov (4):
parallels: list domains with parallels SDK
parallels: implement lookup functions with SDK
parallels: move IS_CT macro to parallels_utils.h
parallels: change domains state with SDK
src/parallels/parallels_driver.c | 178 +-----
src/parallels/parallels_sdk.c | 1189
++++++++++++++++++++++++++++++++++++++
src/parallels/parallels_sdk.h |
14 +
src/parallels/parallels_utils.h | 3 +
4 files changed, 1230 insertions(+), 154 deletions(-)
--
Dmitry Guryanov
Attachments:
- attachment.html (text/html — 8.1 KB)