Re: [libvirt] [PATCH v6 1/5] domain: Add optional 'disableTLS' attribute for TCP chardev
On 09/12/2016 04:26 AM, Daniel P. Berrange wrote:
On Fri, Sep 09, 2016 at 04:49:04PM -0400, John Ferlan wrote:
> Add an optional "disableTLS='yes'" option for a TCP chardev for
the
> express purpose to not enable setting up TLS for the chardev
Can we just call this "tls=yes|no" - negative attributes (disableFOO)
are kind of ugly IMHO, as they imply that the default status is
enabled, which is not really the case - the default is hypervisor
specific and undefined.
That's fine - just changes subsequent patches slightly and alters the
description slightly.
Is a domain_conf.c name like haveTLS OK? I need to differentiate from
'tlscreds' which is used internally to add the 'tls-creds' and would
true when "both" tls='yes' is set in XML and 'chardev_tls=1' in
qemu.conf is set.
John