On Fri, Dec 10, 2021 at 02:52:55PM +0100, Peter Krempa wrote:
On Fri, Dec 10, 2021 at 11:37:29 +0000, Daniel P. Berrangé wrote:
While some SEV info is reported in the domain capabilities, for reasons of size, this excludes the certificates. The nodesevinfo command provides the full set of information.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- docs/manpages/virsh.rst | 14 +++++++++++++ tools/virsh-host.c | 45 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 59 insertions(+)
diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index 1a74217625..e828f7ef68 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -479,6 +479,20 @@ Returns memory stats of the node. If *cell* is specified, this will print the specified cell statistics only.
+nodesevinfo +----------- + +**Syntax:** + +:: + + nodesevinfo + +Reports information about the AMD SEV launch security features for +the node, if any. Some of this information is also reported in the +domain capabilities XML document.
In this instance it wouldbe IMO higly beneficial to mention the individual macros [1] that can be returned in the API docs:
https://www.libvirt.org/html/libvirt-libvirt-host.html#virNodeGetSEVInfo
And link to the API docs here. Duplicating the docs isn't great but not documenting what you get isn't either.
I didn't do any of this in the v3, but I'll look at doing a separate series to improve the docs here.
[1]: https://www.libvirt.org/html/libvirt-libvirt-host.html#VIR_NODE_SEV_CBITPOS https://www.libvirt.org/html/libvirt-libvirt-host.html#VIR_NODE_SEV_CERT_CHA... https://www.libvirt.org/html/libvirt-libvirt-host.html#VIR_NODE_SEV_PDH https://www.libvirt.org/html/libvirt-libvirt-host.html#VIR_NODE_SEV_REDUCED_...
(It's unfortunate that these don't have a common anchor to link to)
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|