On Thu, Jul 24, 2008 at 09:39:36AM +0100, Daniel P. Berrange wrote:
On Tue, Jul 22, 2008 at 05:23:00PM +0100, Daniel P. Berrange wrote:
On Tue, Jul 22, 2008 at 04:53:19PM +0100, Daniel P. Berrange wrote:
There was a good reason for removing the 127.0.0.1 from the XML parsing stage, but i can't remember what it is :-) Anyway this should really be handled at the point where we build the command line in the qemu driver code
Oh I remember now - both Xen and QEMU have a global default setting for VNC listen (/etc/libvirt/qemu.conf and /etc/xen/xend-config.sxp). So, if we default to '127.0.0.1' in the parser, we'll always override the global hypervisor default setting. Hence we need to apply any defaults in the individual drivers at time of guest creation (if it is applicable).
Here's a suggested patch for this:
diff -r 59140de4e7a9 src/qemu_driver.c --- a/src/qemu_driver.c Mon Jul 21 18:27:29 2008 +0100 +++ b/src/qemu_driver.c Tue Jul 22 22:12:22 2008 +0100 @@ -769,9 +769,14 @@ maxcpu = nodeinfo.cpus;
CPU_ZERO(&mask); - for (i = 0 ; i < maxcpu ; i++) - if (vm->def->cpumask[i]) + if (vm->def->cpumask) { + for (i = 0 ; i < maxcpu ; i++) + if (vm->def->cpumask[i]) + CPU_SET(i, &mask); + } else { + for (i = 0 ; i < maxcpu ; i++) CPU_SET(i, &mask); + }
for (i = 0 ; i < vm->nvcpupids ; i++) { if (sched_setaffinity(vm->vcpupids[i],
NB, I explicitly set the affinity if none is specified - this makes sure the children don't inherit any bogus affinity from the libvirtd daemon itself
I don't see how this relates to VNC listening parameters, but this still sounds a good idea :-) +1 Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/