Re: [libvirt] [PATCH v2 13/25] qemu: Support interface model=virtio-{non-}transitional
On Wed, 2019-01-23 at 16:32 -0500, Cole Robinson wrote:
@@ -472,9 +472,15 @@ qemuBuildVirtioDevStr(virBufferPtr buf,
ntmodel_cap = QEMU_CAPS_DEVICE_VIRTIO_BLK_PCI_NON_TRANSITIONAL;
break;
+ case VIR_DOMAIN_DEVICE_NET:
+ has_tmodel = STREQ_NULLABLE(device.data.net->model,
"virtio-transitional");
+ has_ntmodel = STREQ_NULLABLE(device.data.net->model,
"virtio-non-transitional");
+ tmodel_cap = QEMU_CAPS_DEVICE_VIRTIO_NET_PCI_TRANSITIONAL;
+ ntmodel_cap = QEMU_CAPS_DEVICE_VIRTIO_NET_PCI_NON_TRANSITIONAL;
+ break;
Same comment as the previous patch, but I assume you're gonna
either change all of them or none of them, so I'm not gonna repeat
it for every patch :)
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization