Re: [libvirt] [PATCH] virsh: avoid compiler warning on mingw

29 Apr 2011


      2011/4/28 Eric Blake <eblake@redhat.com>:
...
We don't use gnulib's sanitizations for vfprintf, but vshDebug
was used with %zu, which means that it would fail on mingw.
Thank goodness the compiler indirectly caught this for us :)
virsh.c: In function 'vshDebug':
virsh.c:12105:5: warning: function might be possible candidate for
'ms_printf' format attribute [-Wmissing-format-attribute]
since mingw <stdio.h> hasn't yet added gcc attributes to vfprintf.
* tools/virsh.c (vshDebug): Avoid vfprintf.
(vshPrintExtra): Use lighter-weight fputs.
Reported by Matthias Bolte.
---
 tools/virsh.c |   11 +++++++++--
 1 files changed, 9 insertions(+), 2 deletions(-)
Fixes the warning, ACK.

Matthias