Re: [libvirt] [PATCH 1/6] tests: add test cases for default sound output
On 11/14/2017 08:45 AM, Pavel Hrdina wrote:
These test cases models current situation where there is no way how
to specify sound output and that it's based on which graphic device
is the last one.
Personally had a hard time parsing what the commit message said, but
based on what happens 2 patches from now, I think you're just trying to
add vm's w/ a sound device. Not so sure it's the "default" sound device
or just "a" sound device. Not sure how much clearer you could make
things or if it really matters - I'll leave it up to you to reread and
be sure what's happening is what you expect!
Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
---
.../qemuxml2argv-sound-default-output-sdl.args | 23 ++++++++++++++++++++
.../qemuxml2argv-sound-default-output-sdl.xml | 24 +++++++++++++++++++++
...emuxml2argv-sound-default-output-spice-vnc.args | 25 ++++++++++++++++++++++
...qemuxml2argv-sound-default-output-spice-vnc.xml | 25 ++++++++++++++++++++++
.../qemuxml2argv-sound-default-output-spice.args | 24 +++++++++++++++++++++
.../qemuxml2argv-sound-default-output-spice.xml | 24 +++++++++++++++++++++
...emuxml2argv-sound-default-output-vnc-spice.args | 25 ++++++++++++++++++++++
...qemuxml2argv-sound-default-output-vnc-spice.xml | 25 ++++++++++++++++++++++
.../qemuxml2argv-sound-default-output-vnc.args | 24 +++++++++++++++++++++
.../qemuxml2argv-sound-default-output-vnc.xml | 24 +++++++++++++++++++++
tests/qemuxml2argvtest.c | 22 +++++++++++++++++++
11 files changed, 265 insertions(+)
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-sound-default-output-sdl.args
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-sound-default-output-sdl.xml
create mode 100644
tests/qemuxml2argvdata/qemuxml2argv-sound-default-output-spice-vnc.args
create mode 100644
tests/qemuxml2argvdata/qemuxml2argv-sound-default-output-spice-vnc.xml
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-sound-default-output-spice.args
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-sound-default-output-spice.xml
create mode 100644
tests/qemuxml2argvdata/qemuxml2argv-sound-default-output-vnc-spice.args
create mode 100644
tests/qemuxml2argvdata/qemuxml2argv-sound-default-output-vnc-spice.xml
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-sound-default-output-vnc.args
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-sound-default-output-vnc.xml
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John