Re: [libvirt] [PATCH v2 1/2] qemu: Fix "boolen" typo in API doc

Please use --cover-letter for series with two or more patches for neater alignment of e-mails. On Wed, Mar 27, 2019 at 12:21:24PM +0100, Christophe Fergeau wrote: > This also adjusts the argument name which should be 'isListen' in both > cases rather than 'listen'. > > Signed-off-by: Christophe Fergeau <cfergeau(a)redhat.com&gt; > --- > Changes since v1: > - really fix 'boolen' typo > > src/qemu/qemu_command.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c > index f81d20e5f7..82675c5d4e 100644 > --- a/src/qemu/qemu_command.c > +++ b/src/qemu/qemu_command.c > @@ -876,7 +876,7 @@ qemuBuildRBDSecinfoURI(virBufferPtr buf, > > /* qemuBuildTLSx509BackendProps: > * @tlspath: path to the TLS credentials > - * @listen: boolen listen for client or server setting > + * @isListen: boolean listen for client or server setting Both the rename and the typo fix could be qualified as trivial. However the description does not make much sense to me.

> * @verifypeer: boolean to enable peer verification (form of authorization) peer verification is also used for authentication, as of commit 441d3eb6d1be940a67ce45a286602a967601b157 (tag: CVE-2017-1000256)