Re: [libvirt] [libvirt-jenkins-ci PATCH v2 0/6] Unattended guest installation and more
On Wed, Oct 18, 2017 at 07:11:45PM +0200, Andrea Bolognani wrote:
Changes from [v1]:
* guest changes
- set root password to a user-provided value
- only allow key-based SSH login for root
- configure serial console for emergency access
- disable audio, video and USB
- allocate 256 MiB for swap instead of 2 GiB
Why wap in such a virtual machine?
- allocate 15 GiB for storage instead of 10 GiB
- use host-passthrough CPU mode
- set timezone to UTC
* tool changes
- rename to lcitool
- implement basic configuration support
- refuse to run from outside the source directory
- provide better error messages
* others
- improve documentation, mainly the host setup part
[v1] https://www.redhat.com/archives/libvir-list/2017-October/msg00651.html
I can't speak about the installation decisions, that's something that was
already used anyway, I guess, but apart from that, it's pretty neat if I do say
so myself.
I'd ACK it, but I see Dan and Pavel have more insight into this, so I'll let
them do a proper review, just wanted to point out that I think this is something
which will streamline not only our Jenkins CI, but other things as well. Maybe
we'll need to rename the repo then :D
Have a nice noodles^Wday,
Martin
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)