Re: [libvirt] [PATCH 1/5] qemuDomainDetachChrDevice: Use @tmpChr to build device string
$SUBJ:
qemu: Use @tmpChr in qemuDomainDetachChrDevice to build device string
On 2/11/19 10:40 AM, Michal Privoznik wrote:
So far we are passing @chr to qemuBuildChrDeviceStr. This is
suboptimal beacuse @chr is just parsed XML definition provided by
because
user which by definition may lack some information. On the other
hand, @tmpChr is the one that was found using @chr in domain
definition so it contains the same amount of information or more.
It's more than suboptimal, it ends up being wrong since 24b082192 -
looks like a copy-pasta error to me from Attach code...
I'd probably just go with we need to be sure to use the @tmpChr
definition we just found via virDomainChrFind since it contains more
details used when creating the command line that we'll need when
rebuilding that command line.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/qemu/qemu_hotplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John