16 Aug
2010
16 Aug
'10
9:46 p.m.
On Mon, 2010-08-16 at 14:33 -0500, Jamie Strandboge wrote:
On Mon, 2010-08-16 at 17:14 +0100, Daniel P. Berrange wrote:
You can't blindly de-reference data.file.path - The 'file' struct is inside a union and is only valid for certain types of character device VIR_DOMAIN_CHR_TYPE_PTY, TYPE_DEV, TYPE_FILE and TYPE_PIPE. The existing code for serial devices is broken too & can crash due to this
Hrmm. I always did it this. Maybe something changed and I missed it. Regardless, thanks for this feedback! :) Attached is an updated patch.
I didn't come out right. I meant I always did it in the wrong way, and am glad to get this cleaned up. -- Jamie Strandboge | http://www.canonical.com