Re: [libvirt] [PATCH 1/3] qemu_hotplug: remove union for one member

On 10/24/2016 08:41 AM, Pavel Hrdina wrote:

Currently the union has only one member so remove that union. If there is a need to add a new type of source for new bus in the future this will force the author to add a union and properly check bus type before any access to union member.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com> --- src/conf/domain_conf.c | 23 +++++++++++------------ src/conf/domain_conf.h | 4 +--- src/qemu/qemu_command.c | 2 +- src/qemu/qemu_hotplug.c | 4 ++-- 4 files changed, 15 insertions(+), 18 deletions(-)

ACK John