On Mon, Oct 22, 2012 at 04:22:53PM -0600, Jim Fehlig wrote:
Bamvor Jian Zhang wrote:
This patch introduce a lock for protecting the long-running api (save, dump, migration and so on) from the other api which may update the status of the virtual machine.
Hi Bamvor,
Thanks for the patches and sorry for the delayed response. I've been traveling quite a bit lately and just got around to reviewing and testing your work.
Testing so far looks good. I can save and dump vm's while at the same time list and retrieve info.
See my comments inline, but did want to raise a more general comment first. There is a quite a bit of code here borrowed from the qemu driver, which in general is fine since the libxl driver does not need the same locking features as the qemu one. I'd like to hear the opinion of other libvirt maintainers wrt the duplicated code.
I was actually quite pleased to see that the libxl driver was following the model used in the QEMU driver, even though there was code copying. I don't think it is worth trying to eliminate the code duplication in this case. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|