Re: [libvirt] [PATCH 4/4] qemu: snapshot: Fix return value of external checkpoint with no disks
On 05/20/14 18:21, Eric Blake wrote:
On 05/20/2014 10:16 AM, Eric Blake wrote:
> So I'm not quite sure where you are heading with this patch - is the
> idea that we WANT to allow an external checkpoint with no disks, and
> this is fixing a bug that gave an unknown error, or is this a case where
> we want to forbid diskless external checkpoints, and you are just
> improving the error message?
More concretely, I _want_ to allow a memory-only external snapshot
Well, this patch exactly does that. That's why there's no "after" error
message.
The commit message isn't probably clear enough.
How about changing one of the sentences to:
Rework early failure checking and set the error code to success before
iterating the array of disks so that we return success if no disks are
snapshotted.
(particularly of a diskless VM). If this patch is fixing a bogus
error
message into allowing that case, then please touch up the commit message
to make that a bit more clear, and I'm fine with including the patch (my
initial read was that this patch is just improving error message quality
but still leaving it an error, but on reflection it looks like I
mis-read the intent because of confusion about the commit message).
Peter
Attachments:
- signature.asc (application/pgp-signature — 901 bytes)