On 10/21/2011 06:55 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange"<berrange(a)redhat.com>
The QEMU monitor command 'add_client' can be used to connect to
a VNC or SPICE graphics display. This allows for implementaton
s/implementaton/implementation/
of the virDomainOpenGraphics API
* src/qemu/qemu_driver.c: Implement virDomainOpenGraphics
* src/qemu/qemu_monitor.c, src/qemu/qemu_monitor.h,
src/qemu/qemu_monitor_json.c, src/qemu/qemu_monitor_json.h,
src/qemu/qemu_monitor_text.c, src/qemu/qemu_monitor_text.h:
Add binding for 'add_client' command
---
src/qemu/qemu_driver.c | 71 ++++++++++++++++++++++++++++++++++++++++++
src/qemu/qemu_monitor.c | 33 +++++++++++++++++++
src/qemu/qemu_monitor.h | 6 +++
src/qemu/qemu_monitor_json.c | 27 ++++++++++++++++
src/qemu/qemu_monitor_json.h | 5 +++
src/qemu/qemu_monitor_text.c | 32 +++++++++++++++++++
src/qemu/qemu_monitor_text.h | 5 +++
7 files changed, 179 insertions(+), 0 deletions(-)
+
+ if (qemuDomainObjBeginJobWithDriver(driver, vm, QEMU_JOB_MODIFY)< 0)
+ goto cleanup;
+ qemuDomainObjEnterMonitorWithDriver(driver, vm);
+ ret = qemuMonitorOpenGraphics(priv->mon, protocol, fd, "graphicsfd",
+ flags& VIR_DOMAIN_OPEN_GRAPHICS_SKIPAUTH);
'flags & bit' cannot portably convert to <stdbool.h> under the rules of
gnulib's replacement <stdbool.h> (yes, C99 requires it to work, but all
the world is not C99). This has to be:
(flags & VIR_DOMAIN_OPEN_GRAPHICS_SKIPAUTH) != 0
with the explicit comparison to force a bool result.
ACK with that fixed.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library
http://libvirt.org