Re: [libvirt] [PATCHv2 1/3] virsh: modify vshStringToArray to duplicate the elements too

>> +++ b/tools/virsh.h >> @@ -37,6 +37,7 @@ >> # include "virerror.h" >> # include "virthread.h" >> # include "virnetdevbandwidth.h" >> +# include "virstring.h" > > Is this change necessary? > It's to import virStringFreeList to virsh as it's used to free the string list from vshStringToArray in most places. Adding it to the corresponding files calling it might save half of the includes though. I can change it to separate includes if you wish so.