Re: [libvirt] [PATCHv4 01/18] blockjob: add qemu capabilities related to block jobs

On 04/10/2012 11:24 AM, Daniel P. Berrange wrote: I'll push hard on the qemu folks to at least commit to the qapi for qemu 1.1, even if the implementation is not available until after that point, but I can live with the decision to not push the parts depending on the new monitor commands. This brings up some corollary questions: patch 3/18 depends on the new monitor command only insofar as it uses the existence of the command as a way to sanely tell if 'block_job_cancel' is asynchronous or synchronous. I may be able to rework that into something that doesn't depend on 'drive-mirror's existence, by instead tracking whether an event has been issued; is it worth me spending time on this effort, or should I wait for the qemu reaction to committing to 'drive-mirror' first? patch 2/18 and 4/18 are independent fixes, which could be pushed now without waiting for 1/18. Should I pursue this course of action? It is only in 1/18, as well as in 5/18 and later, where we are treading on the dangerous ground of committing to a libvirt API without a reference implementation in qemu; and even then, we can choose whether to commit to the libvirt API without immediate qemu support. All that said, I'd still appreciate a review of the full series, to catch any other potential mistakes while the code is still fresh on my mind, even if we delay pushing it to libvirt.git until qemu has made more progress. -- Eric Blake eblake(a)redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org