Re: [libvirt] [PATCH v2] esx: Add read-only storage pool access
On 05/18/2010 10:38 AM, Matthias Bolte wrote:
Allows listing existing pools and requesting information about them.
Alter the esxVI_ProductVersion enum in a way that allows to check for
product type by masking.
Changes in v2:
- split not directly related parts into separate patches
It's been a week since you posted (sorry for the backlog); I think all
those separated parts are now in, right?
- simplify goto usage: don't jump backwards
- rework format of esxVI_ProductVersion values and explain the format
- expand a FIXME in esxStoragePoolGetXMLDesc
Looks good; you covered everything I mentioned against v1, and my read
through this v2 didn't spot any obvious holes.
ACK.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)