Re: [libvirt PATCH 7/8] rpm: Switch to new macros for handling of systemd units
On Fri, Jul 14, 2023 at 04:39:41PM +0200, Andrea Bolognani wrote:
In most cases the replacement is straightforward, with the
biggest difference being that we now schedule restarts during
%pre instead of %post. This also means that we can get rid of
%post for most packages, reducing the number of scriptlets that
need to run during install/upgrade.
Notable exceptions are libvirt-guests.service, where we stop
using the standard systemd macros to adopt our custom ones, as
well as the virtlogd and virtlockd services, where the reload
operation is moved from %postun to %posttrans.
That would mean the reload is called on package install, but that's
still better than nothing. Feel free to add [ "$1" -gt 1 ] around it
somewhere if you want, but I don't think that's necessary.
Reviewed-by: Martin Kletzander <mkletzan(a)redhat.com>
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)