Re: [libvirt] [PATCH v2] qemu_migration: Avoid crashing if domain dies too quickly
On 10/11/2013 06:14 AM, Michal Privoznik wrote:
I've noticed a SIGSEGV-ing libvirtd on the destination when the
qemu
died too quickly = in Prepare phase. What is happening here is:
4) [Thread 3262] So the even loop starts triggering EOF:
s/even/event/
The mon->vm is set in qemuMonitorOpenInternal() which is the correct
place to increase @vm ref counter. The correct place to decrease the ref
counter is then qemuMonitorDispose().
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
It turned out the hack from v1 is no longer needed. In fact, my reasoning there
flavouring the hack was flawed.
ACK.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)