Re: [libvirt] [PATCHv3 06/10] storage: simplify fd handling
On 03/04/2011 01:15 AM, Paolo Bonzini wrote:
On 03/04/2011 01:37 AM, Eric Blake wrote:
> - unsigned int flags ATTRIBUTE_UNUSED)
> + unsigned int flags)
Uhm, you're still not using the flags, you're just using the argument as
a place to write the flags for virFileOperation. Perhaps the "inner"
flags variable should be renamed?
Actually, I did use the flags - the virCheckFlags(0,-1) added at the top
of the function is a macro that uses the incoming argument. But yes,
repurposing the incoming argument is confusing, I'll rename the second
use of flags to something else.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)