Re: [libvirt] [PATCH] build: avoid infinite autogen loop

On 10/01/2012 11:48 AM, Eric Blake wrote: > Several people have reported that if the .gnulib submodule is dirty, > then 'make' will go into an infinite loop attempting to rerun bootstrap, > because that never cleans up the dirty submodule. By default, we > should halt and make the user investigate, but if the user doesn't > know why or care that the submodule is dirty, I also added the ability > to 'make CLEAN_SUBMODULE=1' to get things going again. > > Also, while testing this, I noticed that when a submodule update was > needed, 'make' would first run autoreconf, then bootstrap (which > reruns autoreconf); adding a strategic dependency allows for less work. > > * .gnulib: Update to latest, for maint.mk improvements. > * cfg.mk (_autogen): Also hook maint.mk, to run before autoreconf. > * autogen.sh (bootstrap): Refuse to run if gnulib is dirty, unless > user requests discarding gnulib changes. ACK. I had saved a directory that was giving me this problem, applied this patch, and the loop was broken! (I added CLEAN_SUBMODULE=1 as suggested, and this fixed the build).