Re: [libvirt] [PATCH 2/4] Revert "error: Add VIR_ERR_DEPRECATED error code"
On Wed, Jun 26, 2019 at 04:54:41PM +0100, Daniel P. Berrangé wrote:
This reverts commit 226094fbc483128c8888f4171c353aed738b8346.
A deprecation is a warning to something that use of a feature is
being discouraged. By definition it is not an error condition to
continue to use a deprecated feature.
Makes sense that from an app's PoV it's the same
A VIR_ERR_DEPRECATED constant thus makes no conceptual sense. For
features which are entirely absent we already document that the
VIR_ERR_NO_SUPPORT code will be used. There is no need to distinguish
between a feature which never existed and a feature which previously
existed and was since removed.
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
include/libvirt/virterror.h | 1 -
src/util/virerror.c | 4 ----
2 files changed, 5 deletions(-)
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Jano
Attachments:
- signature.asc (application/pgp-signature — 488 bytes)