On 03/22/2011 10:23 AM, Daniel P. Berrange wrote:
The Open Nebula driver has been unmaintained since it was first introduced. The only commits have been for tree-wide cleanups. It also has a major design flaw, in that it only knows about guests that it has created itself, which makes it of very limited use.
Discussions wrt evolution of the VMWare ESX driver, concluded that it should limit itself to single-node ESX operation and not try to manage the multi-node architecture of VirtualCenter. Open Nebula is a cluster like Virtual Center, not a single node system, so reasoning applies.
s/so reasoning/so the same reasoning/
The DeltaCloud project includes an Open Nebula driver and is a much better fit architecturally, since it is explicitly targetting the distributed multihost cluster scenario.
Thus this patch deletes the libvirt Open Nebula driver with the recommendation that people use DeltaCloud for managing it instead.
Given your arguments, I'm okay with the idea, but like Laine pointed out, it might be wise to get feedback from the opennebula guys first (commit b811851 shows that Abel Míguez Rodríguez was the original contributor in May 2009, now in cc).
* configure.ac: Remove probe for xmlrpc & --with-one arg * daemon/Makefile.am, daemon/libvirtd.c, src/Makefile.am: Remove ONE driver build * src/opennebula/one_client.c, src/opennebula/one_client.h, src/opennebula/one_conf.c, src/opennebula/one_conf.h, src/opennebula/one_driver.c, src/opennebula/one_driver.c: Delete files * autobuild.sh, libvirt.spec.in, mingw32-libvirt.spec.in: Remove build rules for Open Nebula * docs/drivers.html.in, docs/sitemap.html.in: Remove reference to OpenNebula * docs/drvone.html.in: Delete file
As for the patch itself, I think you got most of the places that referred to ONE or OpenNebula. You missed docs/api_extension, but that was just demonstrating how to stub a new function into existing drivers and represents a historically accurate snapshot, so that's okay. You also left VIR_FROM_ONE in include/libvirt/virterror.h; although you can't really delete that (for back-compat API reasons) you might want to add a comment that it is deprecated. You missed po/POTFILES.in ('make syntax-check' won't catch uncommitted file additions or deletions, unfortunately). You also missed a mention in tools/virsh.pod. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org