Re: [libvirt] [PATCH 3/5] util: Introduce virFileMoveMount
On Wed, Jan 11, Michal Privoznik wrote:
This is a simple wrapper over mount(). However, not every system
out there is capable of moving a mount point. Therefore, instead
of having to deal with this fact in all the places of our code we
can have a simple wrapper and deal with this fact at just one
place.
+++ b/src/util/virfile.c
+ const unsigned long mount_flags = MS_MOVE;
This fails to compile on systems without MS_MOVE, like openSUSE 11.4.
configure checks all sorts of things, perhaps it should detect the
presence of MS_MOVE as well and do the appropriate action.
[ 306s] util/virfile.c:3618:39: error: 'MS_MOVE' undeclared (first use in this
function)
Olaf
Attachments:
- signature.asc (application/pgp-signature — 195 bytes)