Re: [libvirt] [PATCH 3/3] qemu: bulk stats: Don't access possibly blocked storage
On Wed, May 18, 2016 at 15:14:29 +0200, Peter Krempa wrote:
When libvirt is gathering stats for block devices in the bulk stats
API
it would use the fallback code that accesses the files directly in
libvirt both if the VM was offline and if qemu didn't return the stats
at all.
It took me a while to understand what you wanted to say here. It would
be nice if you could reword it :-)
If qemu is not cooperating due to being stuck on an inaccessible NFS
share we would then attempt to read the files and get stuck too with
the VM object locked. All other APIs would get eventually get stuck
s/ get / /
waiting on the VM lock.
Avoid this problem by skipping the block stats if the VM is online but
the monitor did not provide any stats.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1337073
---
src/qemu/qemu_driver.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
ACK
Jirka