Re: [Libvir] Add port number to <graphics> tag
On Tue, Aug 08, 2006 at 10:31:38AM -0400, Daniel Veillard wrote:
On Mon, Aug 07, 2006 at 11:41:48PM +0100, Daniel P. Berrange wrote:
> On Mon, Aug 07, 2006 at 10:40:11PM +0100, Daniel P. Berrange wrote:
> > Yeah sounds resonable to me. I'll take a crack at implementing these two
> > additions to the XML doc and post a patch for review when I have something
> > reasonable working.
>
> See attached patch which looks up port number in xenstore & also pulls
> out the serial console tty.
looks perfect, I would just nitpick about the use of atoi which doesn't catch
errors (strtol is better I guess). And also the fact that the patch to
format.html should really be applied to libvir.html because all htmls are
generated from it via the stylesheets (make rebuild in doc directory).
Attached an updated patch using strol (i had copied the use of atoi from
other methods in that xs_internal.h file though ;-). Also made the changes
to libvir.html instead.
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
Attachments:
- libvirt-xml.patch (text/plain — 14.9 KB)