[libvirt] Re: [Libvir] [PATCH] sound support for qemu and xen
On Tue, May 06, 2008 at 10:39:53AM -0400, Cole Robinson wrote:
Cole Robinson wrote:
> The patch below adds xml support for the soundhw option to qemu
> and xen.
Third iteration. Changes include:
- Rediffd against current code
- Reading 'all' from a xend sexpr or xm config does the right thing.
- Added test files.
Great, this looks good now
- Addressed most of Jim's feedback. Unfortunately I could not
reuse
the qemu sound functions, as xen (on f8 at least) doesn't support
the pcspk model, so the whitelist isn't the same between the two.
I don't think its a huge deal to have separate code for Xen vs QEMU.
The entire XML parser needs to be merged - just dealing with the sound
functions is such a minor deal its not worth it.
Regards,
Daniel.
--
|: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|