Re: [libvirt PATCH 0/3] Invalidate the cpu flags cache on changes of kernel command line
On Thu, Aug 05, 2021 at 03:36:37PM +0200, Tim Wiederhake wrote:
The kernel command line can contain settings affecting the
availability
of cpu features, eg. "tsx=on". This series adds the kernel command line
to the cpu flags cache and declares the cache invalid if the current
kernel command line differs.
Multiple things can change the CPU features. kernel version,
microcode version, bios settings change, kernel command line. We've
been playing whack-a-mole in cache invalidation for ages adding ever
more criteria for things which have side effects on CPU features
available.
Running the CPUID instruction is cheap. Could we directly query the
set of host CPUID leaves we care about, and compare that, and
potentially even get rid of some of the other checks we have ?
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|