Re: [libvirt] [PATCH] tests: qemuxml2argv: Add tests for USB controller on q35
On Fri, 2016-01-08 at 19:05 +0100, Martin Kletzander wrote:
On Fri, Jan 08, 2016 at 06:54:32PM +0100, Andrea Bolognani wrote:
> ---
> .../qemuxml2argv-usb-controller-default-q35.args | 21 +++++++++++++++++
> .../qemuxml2argv-usb-controller-default-q35.xml | 27 ++++++++++++++++++++++
> ...argv-usb-controller-default-unavailable-q35.xml | 27 ++++++++++++++++++++++
> .../qemuxml2argv-usb-controller-explicit-q35.args | 21 +++++++++++++++++
> .../qemuxml2argv-usb-controller-explicit-q35.xml | 27 ++++++++++++++++++++++
> ...rgv-usb-controller-explicit-unavailable-q35.xml | 27 ++++++++++++++++++++++
You could've just symlinked those '-unavailable' files to the other ones
since they are the same.
Right, will do.
Other than that, it looks fine. And works even with my ppc64 fix on
top
of that =).
Considering that I wrote the tests to make sure your ppc64 fix
was not messing with q35 stuff, I expected as much ;)
ACK,
Thanks, will push in a while after converting the duplicate files
to symlinks.
Cheers.
--
Andrea Bolognani
Software Engineer - Virtualization Team