Re: [libvirt] [PATCH 0/5] vbox: remove extra spaces
On 02/09/2016 07:12 AM, Ján Tomko wrote:
Ján Tomko (5):
vbox: remove extra spaces from macro definitions
vbox: remove extra spaces from variable initializations
vbox: remove extra spaces from assignments
vbox: remove extra spaces from function headers
vbox: remove more extra spaces
src/vbox/vbox_V2_2.c | 4 +-
src/vbox/vbox_V3_0.c | 4 +-
src/vbox/vbox_V3_1.c | 4 +-
src/vbox/vbox_V3_2.c | 4 +-
src/vbox/vbox_V4_0.c | 4 +-
src/vbox/vbox_V4_1.c | 4 +-
src/vbox/vbox_V4_2.c | 4 +-
src/vbox/vbox_V4_2_20.c | 4 +-
src/vbox/vbox_V4_3.c | 4 +-
src/vbox/vbox_V4_3_4.c | 4 +-
src/vbox/vbox_XPCOMCGlue.c | 6 +-
src/vbox/vbox_common.c | 317 +++++++++++++++++++++---------------------
src/vbox/vbox_common.h | 4 +-
src/vbox/vbox_snapshot_conf.c | 4 +-
src/vbox/vbox_storage.c | 2 +-
src/vbox/vbox_tmpl.c | 187 ++++++++++++-------------
src/vbox/vbox_uniformed_api.h | 2 +-
17 files changed, 282 insertions(+), 280 deletions(-)
That felt painstakingly monotonous! Patch 5 had a couple of #define's
that were missed in patch 1 it seems, but the ends justify the means...
ACK series
John
In some places, the coding style is to align things in columns - perhaps
a holdover from days of assembly language coding which was hard enough
to read with the proper alignment.