Re: [libvirt] [PATCH 2/2] event: make deregister return value match docs

On 04/01/14 03:31, Eric Blake wrote: > Ever since their introduction (commit 1509b80 in v0.5.0 for > virConnectDomainEventRegister, commit 4445723 in v0.8.0 for > virConnectDomainEventDeregisterAny), the event deregistration > functions have been documented as returning 0 on success; > likewise for older registration (only the newer RegisterAny > must return a non-zero callbackID). And now that we are > adding virConnectNetworkEventDeregisterAny for v1.2.1, it > should have the same semantics. >

> @@ -7371,6 +7375,9 @@ static int > vboxConnectDomainEventDeregister(virConnectPtr conn, > > vboxDriverUnlock(data); > > + if (cnt >= 0) > + ret = 0; This actually fixes bug, otherwise it always returns -1.

The changes themselvs are just sane. Assuming that the application followed the documentation instead of the code. And since either changing the doc or the code could be able break something, changing the code couldn't be worse than changing the doc. Well, who knows. :-) ACK.