20 Feb
2012
20 Feb
'12
10:43 p.m.
On 02/20/2012 12:46 PM, Laine Stump wrote:
On 02/20/2012 01:48 PM, Eric Blake wrote:
Overall, the idea looks reasonable, but you'll need a v2 to fix the memory issues in qemu_command.c. Actually, there were problems with freeing the hostdevdef on error paths in all 4 places virDomainHostdevDefAlloc() was used :-( I don't know what I was thinking...
I've updated the patch with the following diff and will repost the full patch.
0001-fix-memory-leaks-in-make-hostdev-info-a-separate-obj.patch
ACK to squashing this in. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org