On 06/11/2014 05:45 AM, Peter Krempa wrote:
When the test is failing but the debug output isn't enabled the resulting line would look ugly like and would not contain the actual difference.
TEST: virstoragetest .................chain member 1!chain member 1!chain member 1!
Store the member index in the actual checked string to hide this problem --- tests/virstoragetest.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
I know I'm going pretty slow through my review of the series, but didn't I already ACK this one? At any rate, this one's safe to put in now if it is easy to rebase (and I still have my own patch to this file coming up soon when I rework chain lookup, so I'm trying to miminize conflict churn). -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org