Re: [libvirt] [PATCH v2 06/11] conf: Extend virDomainDeviceDefPostParse for parseOpaque
On Fri, Sep 23, 2016 at 15:24:59 +0200, Michal Privoznik wrote:
Just like virDomainDefPostParseCallback has gained new
parseOpaque argument, we need to follow the logic with
virDomainDeviceDefPostParse.
...
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index a6554f5..37ed6f5 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -2371,12 +2371,16 @@ typedef int (*virDomainDefPostParseCallback)(virDomainDefPtr
def,
void *opaque,
void *parseOpaque);
/* Called once per device, for adjusting per-device settings while
- * leaving the overall domain otherwise unchanged. */
+ * leaving the overall domain otherwise unchanged.
+ * @parseOpaque is opaque data passed by virDomainDefParse* caller,
+ * @opqaue is opaque data set by driver (usually pointer to driver
s/opqaue/opaque/
+ * private data). */
typedef int (*virDomainDeviceDefPostParseCallback)(virDomainDeviceDefPtr dev,
const virDomainDef *def,
virCapsPtr caps,
unsigned int parseFlags,
- void *opaque);
+ void *opaque,
+ void *parseOpaque);
/* Drive callback for assigning device addresses, called at the end
* of parsing, after all defaults and implicit devices have been added. */
typedef int (*virDomainDefAssignAddressesCallback)(virDomainDef *def,
...
ACK
Jirka