Re: [libvirt] [PATCH 06/12] src: convert code to use new socket portability wrappers

On Fri, Jan 10, 2020 at 03:41:10PM +0000, Daniel P. Berrangé wrote:

Convert to use socket wrappers. Aside from the header file include change, this requires changing close -> closesocket since our portability isn't trying to replace the close function.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- src/rpc/virnetsocket.c | 34 +++++++++++++++++++++++----------- src/util/virportallocator.c | 8 +++----- 2 files changed, 26 insertions(+), 16 deletions(-)

I wonder if we should change all the remaining VIR_FORCE_CLOSE and VIR_AUTOCLOSE related to sockets as well to be on a safe side. Reviewed-by: Pavel Hrdina <phrdina@redhat.com>