On 01/07/2014 10:46 AM, Thadeu Lima de Souza Cascardo wrote:
Does the resulting file contain any newlines or carriage returns that might get botched on Windows platforms, if we don't add a .gitattributes listing that mentions it is explicitly a binary file?
make syntax-check seems to work, but some of the files have a newline character. I haven't worked with git on Windows. Is that going to be a problem?
Let's not worry about it until someone reports an actual failure where trying to use the repository in line-ending-munge mode actually breaks things for them (personally, when I use git on Windows, I intentionally use it in binary-only mode because I find line-ending-munge mode causes more problems than it cures). -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org