Re: [libvirt] [PATCH v2] storage: Attempt to refresh volume after successful wipe volume
On Wed, Dec 16, 2015 at 14:28:03 +0100, Martin Kletzander wrote:
On Tue, Dec 15, 2015 at 03:03:33PM -0500, John Ferlan wrote:
>https://bugzilla.redhat.com/show_bug.cgi?id=1270709
>
>When a volume wipe is successful, perform a volume refresh afterwards to
>update any volume data that may be used in future volume commands, such as
>volume resize. For a raw file volume, a wipe could truncate the file and
>a followup volume resize the capacity may fail because the volume target
>allocation isn't updated to reflect the wipe activity.
>
>Since the documentation doesn't mention this side effect of the zero
>algorithm for a raw file volume, update the various documentation to
>describe the results.
Since the volume format is not really considered while wiping, this will
have also various efects on qcow and other storage formats.
>
Oh yes, side effects, we have many of those regarding volume wiping.
For this one, I think you cose the best solution, so even though there
are some other hidden things, at least this is cleaned up a bit now.
Similarly a sparse file will be filled up to the maximum once you use
some of the different algorithms that overwrite the file. Additionally
the storage format will change in that case.
Peter
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)